Skip to content

ty: un-ignore call-non-callable rule - #15582

Open
kukirin-ui wants to merge 1 commit into
TheAlgorithms:masterfrom
kukirin-ui:ty/call-non-callable
Open

kukirin-ui wants to merge 1 commit into
TheAlgorithms:masterfrom
kukirin-ui:ty/call-non-callable

Conversation

@kukirin-ui

Copy link
Copy Markdown

Describe your change

Part of #15187. call-non-callable had a single diagnostic left, in neural_network/back_propagation_neural_network.py: DenseLayer.activation started out as None and was only replaced with sigmoid later in initializer(), so ty saw a call on a possibly None attribute. The default is now resolved in __init__ and the parameter is annotated, which clears the diagnostic, so the rule is removed from the [tool.ty] ignore list. The input layer never calls its activation, so behaviour is unchanged.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants